Fix NPE in ServerGrpcChannelBackoffResetHandler#18139
Draft
timothy-e wants to merge 6 commits intoapache:masterfrom
Draft
Fix NPE in ServerGrpcChannelBackoffResetHandler#18139timothy-e wants to merge 6 commits intoapache:masterfrom
timothy-e wants to merge 6 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18139 +/- ##
============================================
- Coverage 64.01% 63.11% -0.90%
Complexity 1617 1617
============================================
Files 3192 3202 +10
Lines 193936 194724 +788
Branches 29937 30049 +112
============================================
- Hits 124140 122900 -1240
- Misses 59990 62078 +2088
+ Partials 9806 9746 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
reviewed
Apr 8, 2026
| // Both require a full scan to rebuild _shuttingDownServers from the current cluster state. | ||
| NotificationContext.Type type = context.getType(); | ||
| if (type == NotificationContext.Type.INIT || context.getIsChildChange()) { | ||
| String pathChanged = context.getPathChanged(); |
Contributor
There was a problem hiding this comment.
We should dig deeper. Do you see a code path in Helix that can result in null pathChanges?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinot integration tests failed flakily with
getPathChangedcan returnnullwhen the notification type isFINALIZE. This was originally present in the PR that introduced this file, but removed because it was accidentally viewed as redundant.Also, add a defensive null check before using the
pathChanged, since it isn't guaranteed thatpathChangedwill be non-null.