docs: remove outdated single-content-block note from accumulated_text#164
Open
frankgoldfish wants to merge 2 commits intoanthropics:mainfrom
Open
Conversation
'Sybmol' was misspelled in three @param/@return YARD doc comments in helpers/messages.rb. Corrected to 'Symbol'.
The comment 'NOTE: Currently the API will only respond with a single content block.' has been inaccurate since extended thinking was introduced, which causes responses to contain a thinking block followed by a text block. The implementation already concatenates all text blocks correctly; only the misleading documentation note needed removing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a stale documentation note from
accumulated_textinlib/anthropic/helpers/streaming/message_stream.rb.Change
Removes the comment:
# NOTE: Currently the API will only respond with a single content block.from the
accumulated_textmethod.Why
This note was accurate at the time it was written, but has been outdated since extended thinking was introduced. When thinking is enabled the API returns a
thinkingblock followed by atextblock, i.e. multiple content blocks. The implementation already handles this correctly (it maps over all blocks and joins text ones); only the misleading comment needed removing.🤖 Generated with Claude Code