fix(nix): add shared package to bun install filters#22665
Draft
jerome-benoit wants to merge 5 commits intoanomalyco:devfrom
Draft
fix(nix): add shared package to bun install filters#22665jerome-benoit wants to merge 5 commits intoanomalyco:devfrom
jerome-benoit wants to merge 5 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
contributor
needs:compliance
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Nix bun install workspace filter list to include the newly introduced packages/shared workspace so its dependencies are available during sandboxed builds (fixing the reported @tsconfig/bun resolution failure).
Changes:
- Add
--filter './packages/shared'to the filteredbun installinvocation innix/node_modules.nix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The --filter alone is insufficient because @tsconfig/bun was not in shared's own package.json, so bun never installs it for shared in the nix sandbox. Every other package extending @tsconfig/bun declares it in its own devDependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22657
Type of change
What does this PR do?
Adds
--filter './packages/shared'tobun installinnix/node_modules.nix.PR #22626 introduced
packages/sharedas a workspace dependency ofopencode,app, andui. Itstsconfig.jsonextends@tsconfig/bun/tsconfig.json(resolved via the workspace rootcatalog:). Without this filter, bun doesn't install shared's dependencies in the nix sandbox, so vite/esbuild fails resolving the tsconfig chain.The
nix-hashesCI will auto-recompute and commit updated hashes once this lands ondev.How did you verify your code works?
nix eval ".#packages.aarch64-darwin.opencode.drvPath"passes locallyopencode → shared → tsconfig extends @tsconfig/bundesktop.nix,opencode.nixconsumenode_moduleswithout runningbun install)Screenshots / recordings
N/A — build-time fix, no UI change.
Checklist