Abilities: Catch exceptions thrown by ability callbacks#11544
Closed
gziolo wants to merge 1 commit intoWordPress:trunkfrom
Closed
Abilities: Catch exceptions thrown by ability callbacks#11544gziolo wants to merge 1 commit intoWordPress:trunkfrom
gziolo wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Converts any `Throwable` raised by an `execute_callback` or `permission_callback` into a `WP_Error` with code `ability_callback_exception`, instead of letting it propagate uncaught. This prevents the REST ability runner from surfacing a 500 HTML fatal error page when a callback fails (e.g. an AI connector HTTP timeout), and gives clients a predictable JSON error response. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
gziolo
added
the
props-bot
github-actions
bot
removed
the
props-bot
pento
pushed a commit
that referenced
this pull request
Apr 16, 2026
…n WP_Error. Wraps `invoke_callback()` in a try/catch so that exceptions thrown by execute or permission callbacks are converted to a `WP_Error` with the `ability_callback_exception` code instead of propagating as uncaught throwables. Developed in: #11544 Props priyankagusani, jamesgiroux, jeffpaul, dkotter, adamsilverstein, justlevine, jorbin, pavanpatil1. Fixes #65058. git-svn-id: https://develop.svn.wordpress.org/trunk@62238 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 16, 2026
…n WP_Error. Wraps `invoke_callback()` in a try/catch so that exceptions thrown by execute or permission callbacks are converted to a `WP_Error` with the `ability_callback_exception` code instead of propagating as uncaught throwables. Developed in: WordPress/wordpress-develop#11544 Props priyankagusani, jamesgiroux, jeffpaul, dkotter, adamsilverstein, justlevine, jorbin, pavanpatil1. Fixes #65058. Built from https://develop.svn.wordpress.org/trunk@62238 git-svn-id: http://core.svn.wordpress.org/trunk@61518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an ability's
execute_callbackorpermission_callbackthrows an uncaught exception, it propagates throughWP_Ability::execute()and the REST run controller, causing WordPress to render an HTML fatal error page with a 500 status instead of a JSON error response.This was first reported via the Core AI feature plugin when an AI connector's HTTP request to a remote provider timed out after 30 seconds — the underlying client threw a
ServerException, which surfaced to the browser as a full HTML page inside the REST response, breaking client-side error handling.See WordPress/ai#392 for the original report and root-cause analysis.
Fix
WP_Ability::invoke_callback()now catches anyThrowableraised by the callback and converts it to aWP_Errorwith codeability_callback_exception. Becauseinvoke_callback()is shared betweendo_execute()andcheck_permissions(), both callback types are protected by a single change, and the existingis_wp_error()handling inexecute()surfaces the error to the caller unchanged.Trac ticket: https://core.trac.wordpress.org/ticket/65058
Test plan
execute_callbackthat throws — expectsWP_Errorwith codeability_callback_exception.permission_callbackthat throws viacheck_permissions()directly — same code, same behavior.🤖 Generated with Claude Code