Skip to content

✨ Added design customization options for welcome emails#27313

Draft
cmraible wants to merge 2 commits intomainfrom
chris-promote-welcome-emails-customization-to-ga
Draft

✨ Added design customization options for welcome emails#27313
cmraible wants to merge 2 commits intomainfrom
chris-promote-welcome-emails-customization-to-ga

Conversation

@cmraible
Copy link
Copy Markdown
Collaborator

@cmraible cmraible commented Apr 9, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f75cea1c-de9d-49e9-9218-9f631447b6d3

📥 Commits

Reviewing files that changed from the base of the PR and between 905379e and 8b4ecc4.

⛔ Files ignored due to path filters (1)
  • ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • ghost/core/core/shared/labs.js

Walkthrough

The welcomeEmailsDesignCustomization feature flag was promoted from private labs to general availability (GA). This was accomplished by moving the flag from the PRIVATE_FEATURES set to the GA_FEATURES set in the labs configuration file. The change affects three exported modules: GA_KEYS now includes the flag, WRITABLE_KEYS_ALLOWLIST no longer includes it, and getAllFlags() returns the flag as part of the GA set instead of the private set.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'design customization options for welcome emails' but the actual change promotes an existing feature flag from private to GA status, not adding new functionality. Clarify whether the title should reflect the actual change (promoting a feature to GA) or if it refers to the underlying feature being promoted.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relatedness to the changeset. Add a description explaining the purpose of promoting 'welcomeEmailsDesignCustomization' from private to GA status and any relevant context.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chris-promote-welcome-emails-customization-to-ga

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

@cmraible cmraible marked this pull request as ready for review April 9, 2026 17:13
@cmraible cmraible marked this pull request as draft April 9, 2026 17:55
@cmraible
Copy link
Copy Markdown
Collaborator Author

cmraible commented Apr 9, 2026

Reverting to draft, as we've decided to wait on this until Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant