Skip to content

Added gift subscription URL to editor link autocomplete#27306

Merged
minimaluminium merged 1 commit intomainfrom
gift-link-editor-ber-3489
Apr 10, 2026
Merged

Added gift subscription URL to editor link autocomplete#27306
minimaluminium merged 1 commit intomainfrom
gift-link-editor-ber-3489

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3489/ghost-admin-add-gifting-url-to-the-button-card-in-the-editor
ref https://linear.app/ghost/issue/BER-3488/ghost-admin-add-gifting-url-to-the-cta-card-in-the-editor

  • lets publishers promote the new gift subscription flow from posts and emails via Button or CTA cards
  • adds #/portal/gift to the link autocomplete alongside the other portal links
  • picked up automatically by all cards using the shared InputUrlSetting (Button, CTA, Email CTA, Header, Product)
  • gated behind the giftSubscriptions lab flag

- lets publishers promote the new gift subscription flow from posts and emails via Button or CTA cards
- adds #/portal/gift to the link autocomplete alongside the other portal links
- picked up automatically by all cards using the shared InputUrlSetting (Button, CTA, Email CTA, Header, Product)
- gated behind the giftSubscriptions lab flag
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1c5fb5d7-0f6a-4c87-abe4-288d7666ab4c

📥 Commits

Reviewing files that changed from the base of the PR and between 9505bac and 5c2fa36.

📒 Files selected for processing (2)
  • ghost/admin/app/components/koenig-lexical-editor.js
  • ghost/admin/app/services/feature.js

Walkthrough

This change introduces gift subscription link support to the editor's autocomplete functionality. A new giftSubscriptions feature flag was added to FeatureService via the @feature decorator. The koenig-lexical-editor component was updated with a giftLink helper that conditionally returns a "Gift subscription" autocomplete option (linking to #/portal/gift) when the feature flag is enabled. The helper is integrated into the autocomplete links assembly between recommendation and offer links, while maintaining existing member, donation, and other link logic unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a gift subscription URL to the editor's link autocomplete feature.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose, implementation approach, and feature gating of the gift subscription URL addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gift-link-editor-ber-3489

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

@minimaluminium minimaluminium merged commit 0bd1217 into main Apr 10, 2026
37 checks passed
@minimaluminium minimaluminium deleted the gift-link-editor-ber-3489 branch April 10, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants