Skip to content

Added gift member status filter in admin#27294

Open
mike182uk wants to merge 1 commit intomainfrom
BER-3481-add-gift-member-filter-status
Open

Added gift member status filter in admin#27294
mike182uk wants to merge 1 commit intomainfrom
BER-3481-add-gift-member-filter-status

Conversation

@mike182uk
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3481

Added gift member status filter in admin to allow filtering members who have a gift subscription

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7f161a46-c148-4f21-979a-22e7fcd0f492

📥 Commits

Reviewing files that changed from the base of the PR and between 4fbac20 and 53a6fdb.

📒 Files selected for processing (7)
  • apps/admin-x-framework/src/api/members.ts
  • apps/posts/src/views/members/components/members-filters.tsx
  • apps/posts/src/views/members/components/members-list-item.tsx
  • apps/posts/src/views/members/use-member-filter-fields.test.ts
  • apps/posts/src/views/members/use-member-filter-fields.ts
  • ghost/admin/app/components/members/filters/status.js
  • ghost/admin/app/services/feature.js
✅ Files skipped from review due to trivial changes (4)
  • apps/posts/src/views/members/components/members-list-item.tsx
  • apps/posts/src/views/members/components/members-filters.tsx
  • apps/posts/src/views/members/use-member-filter-fields.test.ts
  • apps/admin-x-framework/src/api/members.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • ghost/admin/app/components/members/filters/status.js
  • apps/posts/src/views/members/use-member-filter-fields.ts

Walkthrough

Adds support for a new "gift" member status across admin code: expands the exported Member.type to include 'gift'; surfaces a labs feature flag giftSubscriptions on FeatureService; conditions UI filters and status labels to include a "Gift" option when the feature is enabled; and adds tests validating the conditional filter behavior.

Possibly related PRs

  • TryGhost/Ghost PR 26992 — Adds database schema validation and constraints for the new "gift" member status, aligning core data validation with these UI/type changes.

Suggested reviewers

  • sagzy
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a gift member status filter in the admin interface for filtering gift subscription members.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding a gift member status filter to allow filtering members with gift subscriptions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BER-3481-add-gift-member-filter-status

Comment @coderabbitai help to get the list of available commands and usage tips.

ref https://linear.app/ghost/issue/BER-3481

Added gift member status filter in admin to allow filtering members who
have a gift subscription
@mike182uk mike182uk force-pushed the BER-3481-add-gift-member-filter-status branch from 4fbac20 to 53a6fdb Compare April 9, 2026 20:29
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 24211791713 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants