Merged
Conversation
…umns - Replace passive NSImageView chevron with interactive CellChevronButton - Single click on chevron opens the appropriate editor (boolean dropdown, enum/set popover, date picker, JSON editor, hex editor) - Double click on cell text enters inline editing only - Add chevron to boolean, date, JSON, blob columns (previously had none) - Fix dropdown change tracking: use commitPopoverEdit with changeManager - Fix shouldEdit missing boolean guard (inline edit opened on boolean cells) - Fix cell reuse: always update chevron target/action (prevents dangling pointer) - Fix handleDoubleClick JSON detection running on chevron columns - Fix typePicker priority in handleChevronClick (Structure view compatibility)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify cell editor interaction across all column types in the DataGrid. Previously, some columns opened editors on single click (ENUM/SET), some on double click (date, JSON, blob, FK), and boolean data columns had no special editor at all.
Changes
New behavior model:
Columns that now get a chevron button:
Bug fixes included:
dropdownMenuItemSelectednow usescommitPopoverEditwith properchangeManager.recordCellChange(was bypassing change tracking entirely)shouldEditnow blocks boolean columns from inline editingtarget/actionupdated on every cell reuse (prevents dangling pointer when coordinator changes)Files changed (6)
DataGridCellFactory.swift—CellChevronButtonreplacesNSImageView, new paramsDataGridView+Click.swift—handleChevronClickroutes all editors, simplifiedhandleClick/handleDoubleClickDataGridView+Columns.swift—hasSpecialEditorflag for boolean/date/JSON/blobDataGridView+Editing.swift—shouldEditblocks boolean columnsDataGridView+Popovers.swift— dropdown usescommitPopoverEditDataGridCoordinator.swift—pendingDropdownTableViewpropertyTest plan