Added 'api' event type to Gitlab and added new option --license-file-…#100
Merged
Douglas (dacoburn) merged 2 commits intomainfrom Jul 3, 2025
Merged
Conversation
…name that defaults to license_output.json instead of a dynamic name that could be a bad filename
Douglas (dacoburn)
requested review from
Jeppe Hasseriis (cenobitedk) and
Nolan Lawson (nolanlawson)
and removed request for
a team
Douglas (dacoburn)
added
the
Product Changelog
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.21.dev1Docker image: |
Martin Torp (mtorp)
approved these changes
Jul 3, 2025
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Douglas (dacoburn)
deleted the
doug/fix-license-file-name-and-add-gitlab-event-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…name that defaults to license_output.json instead of a dynamic name that could be a bad filename
Root Cause
The file name that was being generated from the repo and branch was not being serialized to a safe file name that could cause the code to error.
The
apievent type for gitlab wasn't supported which would cause the CLI to error.Fix
--license-file-nameto use for the license file and defaults tolicense_output.jsonPublic Changelog
apievent type for Gitlab--license-file-nameinstead of trying to generate the file name from the repo and branch for a safer license file name.