add aeotec 8 series new#2897
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 72 files 500 suites 0s ⏱️ For more details on these errors, see this check. Results for commit a59dd3e. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a59dd3e |
|
Invitation URL: |
| -- Copyright 2025 SmartThings | ||
| -- | ||
| -- Licensed under the Apache License, Version 2.0 (the "License"); | ||
| -- you may not use this file except in compliance with the License. | ||
| -- You may obtain a copy of the License at | ||
| -- | ||
| -- http://www.apache.org/licenses/LICENSE-2.0 | ||
| -- | ||
| -- Unless required by applicable law or agreed to in writing, software | ||
| -- distributed under the License is distributed on an "AS IS" BASIS, | ||
| -- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| -- See the License for the specific language governing permissions and | ||
| -- limitations under the License. |
There was a problem hiding this comment.
Please use the short form of the copyright/license notice that is being used in the rest of the files. This is an issue with other files too.
| MATCHING_MATRIX = { | ||
| mfrs = 0x0371, | ||
| product_types = {0x0002, 0x0102, 0x0202}, | ||
| product_ids = 0x0018 |
There was a problem hiding this comment.
This is different than what is in the fingerprint. Please double check the product ids for all devices.
| preferenceType: integer | ||
| definition: | ||
| minimum: 0 | ||
| maximum: 2678400 |
There was a problem hiding this comment.
This is higher than what the preference allows. Check the parameter definitions in preferences.lua and change the size to what it should be or update this to match the size of parameter 1.
| end | ||
|
|
||
| local function do_refresh(driver, device) | ||
| device:send(Battery:Get({})) |
There was a problem hiding this comment.
Why not use the default functionality for refresh? This will also read state from the command classes that support the devices capabilities rather than just battery.
| default: 0 | ||
| - name: "parameter13" | ||
| title: "13 Mold alarm offset" | ||
| desccription: "Increase the humidity threshold." |
There was a problem hiding this comment.
| desccription: "Increase the humidity threshold." | |
| description: "Increase the humidity threshold." |
| default: 0 | ||
| - name: "parameter13" | ||
| title: "13 Mold alarm offset" | ||
| desccription: "Increase the humidity threshold." |
There was a problem hiding this comment.
| desccription: "Increase the humidity threshold." | |
| description: "Increase the humidity threshold." |
There was a problem hiding this comment.
This file has bytes on the end of the name that make it hidden to require. It is likely the main cause of the widespread test failures
| device:send(Battery:Get({})) | ||
|
|
||
| device:register_native_capability_attr_handler("temperatureMeasurement", "temperature") | ||
| -- device:register_native_capability_attr_handler("colorControl", "hue") |
There was a problem hiding this comment.
Remove commented out code.
| can_handle = can_handle_aeotec_aerq | ||
| } | ||
|
|
||
| return aeotec_aerq_8 No newline at end of file |
There was a problem hiding this comment.
Add newline to end of this file and any other files that have it missing.
There was a problem hiding this comment.
This subdriver is unnecessary. The aeotec-door-window-sensor-8 handlers cover everything here. Remove this driver, and have the device be handled by that one.
|
I will re-review once the tests are passing. Ill also request that you test your device on a real hub to ensure its functionality is what you expect. |
3 participants
Check all that apply
Type of Change
Checklist
Description of Change
This is a new clean pull request for the new Aeotec Series 8 devices.
Summary of Completed Tests