add multiir_motion_MIR-IR100#2861
add multiir_motion_MIR-IR100#2861thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 503 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 84dc278. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 84dc278 |
6681b2e to
3b5d613
Compare
cjswedes
left a comment
There was a problem hiding this comment.
All of the files added have the executable permission included. They should not. Please re-add them with only read/write permissions. I tested out this and you can do it with git update-index --chmod=-x <file_path> for all the files you have added.
drivers/SmartThings/zigbee-motion-sensor/src/test/test_multiir_motion_pir.lua
Outdated
Show resolved
Hide resolved
| - id: battery | ||
| version: 1 | ||
| - id: refresh | ||
| version: 1 |
There was a problem hiding this comment.
This should have the FW update capability.
There was a problem hiding this comment.
Because the product does not have the firmware update function and version information reporting capabilities. If this capability is added to the profile, the test for this capability in the SmartThings Developer Center Test Suite will fail.
7ae5cb0 to
23af762
Compare
23af762 to
84dc278
Compare
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests