Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this gem!
I found it helpful on [Rice]https://ruby-rice.github.io/4.x/ and now on libxml-ruby.
However, using nokogiri to check libxml_ruby seems weird, and well...wrong. So I updated ruby_memcheck to enable swapping backend xml parsers and included default support for nokogiri and libxml-ruby. I then tested both with nokogiri and libxml-ruby. I left the default require in the gemspec to be nokogiri.
The point of this commit is that it let's me maintain a fork of ruby_memcheck that has only one code change - removing the nokogiri depedency in the gemspec (because if I am testing libxml-ruby I don't need ruby_memcheck to then require libxml-ruby).
I realize this isn't a useful for MR for most other people, but it would make it easy to hook in rexml in the future if someone wanted to use it instead.
Thanks!