fix: stop base64-encoding dist/index.wasm during function builds

[isaacroldan]

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've considered analytics changes to measure impact
• The change is user-facing, so I've added a changelog entry with pnpm changeset add

[isaacroldan]

• fix: stop base64-encoding dist/index.wasm during function builds #7232 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR aims to prevent dist/index.wasm from being base64-encoded during normal function builds by separating “raw build output” from “bundle output” and introducing an explicit bundleOutputPath override for bundle builds.

Changes:

• Add an optional outputPath override to the JS function build pipeline (Javy compile/run) so builds can write artifacts without mutating extension.outputPath.
• Update extension build/bundle logic to support bundleOutputPath, and adjust function build flow to copy raw WASM to the canonical output and only base64-encode for bundle builds.
• Update tests to reflect the new build output/copy semantics and the non-mutation of extension.outputPath.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/app/src/cli/services/function/build.ts	Allows JS function compilation to write WASM to an optional override output path.
packages/app/src/cli/services/extensions/bundle.ts	Uses bundleOutputPath (when present) as the destination for theme/file copy bundling.
packages/app/src/cli/services/build/extension.ts	Introduces bundleOutputPath; updates UI/function build output routing and function bundle/base64 behavior.
packages/app/src/cli/services/build/extension.test.ts	Updates expectations for JS function build output path and raw-binary copy behavior.
packages/app/src/cli/models/extensions/extension-instance.ts	Stops mutating outputPath during bundle builds; passes bundleOutputPath through options and adjusts bundle copying logic.
packages/app/src/cli/models/extensions/extension-instance.test.ts	Updates bundle copy assertions to reflect bundle output paths without relying on mutated outputPath.

Comments suppressed due to low confidence (1)

packages/app/src/cli/services/build/extension.ts:183

• When bundleOutputPath is set, this block copies extension.outputPath to bundleOutputPath and then calls bundleFunctionExtension with the same path as both input and output. This extra touch/copy is redundant and does unnecessary I/O; you can base64-encode directly from extension.outputPath into bundleOutputPath (and avoid the self-read/self-write pattern).

  } catch (error: any) {
    // To avoid random user-code errors being reported as CLI bugs, we capture and rethrow them as AbortError.
    // In this case, we need to keep the ESBuild details for the logs. (the `errors` array).
    // If the error is already an AbortError, we can just rethrow it.
    if (error instanceof AbortError) {
      throw error

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

buildForBundle no longer overrides extension.outputPath and instead passes bundleOutputPath via options, but several deploy build steps write to extension.outputPath directly (e.g., bundle_theme, include_assets, create_tax_stub). As a result, buildForBundle will likely emit artifacts into the extension’s local output path instead of the bundle directory, producing incomplete/incorrect bundles. Either restore a scoped outputPath override for the duration of buildForBundle (and restore afterward), or update all step executors/helpers that use extension.outputPath to prefer options.bundleOutputPath when present.

[Copilot]

The new bundleOutputPath docstring says “build functions write their final artifact here instead of extension.outputPath”, but buildFunctionExtension still writes to extension.outputPath (and only uses bundleOutputPath for bundling/base64 output). Please adjust the comment to match the actual behavior (or update the implementation to truly redirect build output when bundleOutputPath is set).

Suggested change

	* bundle directory. When set, build functions write their final artifact here
	* instead of extension.outputPath. This avoids mutating extension.outputPath at
	* runtime.
	* bundle directory used for bundled output artifacts.
	*
	* Some build flows may still write their final artifact to extension.outputPath,
	* so this option should not be treated as a universal replacement for that path.

[Copilot]

In copyIntoBundle, touchFile(bundleOutputPath) assumes the bundle output is a file path. For specs where outputRelativePath is empty (common for contract-based modules), getOutputPathForDirectory returns a directory path; touching it will create a file at that path and can break the subsequent directory copy. Consider removing touchFile here (fs-extra copy creates parent dirs), or switching to ensuring a directory when bundleOutputPath is a directory.