rust: pin-init: allow dead_code on projection structures#97
Closed
Gnurou wants to merge 1 commit intoRust-for-Linux:mainfrom
Closed
rust: pin-init: allow dead_code on projection structures#97Gnurou wants to merge 1 commit intoRust-for-Linux:mainfrom
dead_code on projection structures#97Gnurou wants to merge 1 commit intoRust-for-Linux:mainfrom
Conversation
Projection structures are not necessarily (and often not) used in their entirety. At the moment partial uses result in warnings about the unused members. Discard them by allowing `dead_code` on the projection structure Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Member
|
Could you also create a test-case to catch regressions? Thanks! (& also rebase, the ui-tests should pass on |
Member
|
Closing as this targets the legacy pre-syn version and the dead_code has been added since. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projection structures are not necessarily (and often not) used in their entirety. At the moment partial uses result in warnings about the unused members.
Discard them by allowing
dead_codeon the projection structure