wgpu template: wgpu 27.0.1 -> 29.0.1, winit FIXME#15
Open
goldnor wants to merge 5 commits intoRust-GPU:mainfrom
Open
wgpu template: wgpu 27.0.1 -> 29.0.1, winit FIXME#15goldnor wants to merge 5 commits intoRust-GPU:mainfrom
goldnor wants to merge 5 commits intoRust-GPU:mainfrom
Conversation
Member
|
The CI will fail, you have to run |
Member
|
Oh yea if you deleted a file, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates wgpu and completes the migration to winit 0.30.13, resolving existing FIXME comments and aligning the implementation with the latest upstream examples. The migration was primarily guided by the official wgpu example.
ApplicationHandlertrait.Surface::get_current_texturenow returnsCurrentSurfaceTextureenum, which simplifies the oldMySwapchainManager::rendermethod (nowState::render)InstanceDescriptorinitialization APIs and display handle changes:Instanceis now recreated onApplicationHandler::resumed, as recommended for platforms with lifecycle management constraints (e.g. mobile; seeApplicationHandler::resumed)