Skip to content

Chore: [AEA-0000] - add ignore-script#1072

Merged
anthony-nhs merged 1 commit intomainfrom
add_ignore_script
Apr 15, 2026
Merged

Chore: [AEA-0000] - add ignore-script#1072
anthony-nhs merged 1 commit intomainfrom
add_ignore_script

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

  • add ignore-script option to npm ci

Copilot AI review requested due to automatic review settings April 15, 2026 10:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an --ignore-scripts flag to the Node dependency install step to prevent npm lifecycle scripts from running during make install-node.

Changes:

  • Update make install-node to run npm ci --ignore-scripts.

Comment thread Makefile

install-node:
npm ci
npm ci --ignore-scripts
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci --ignore-scripts will skip dependency install scripts. This repo depends on esbuild (see package-lock hasInstallScript: true), so make install-node is likely to produce a broken node_modules without the esbuild binary and subsequent TypeScript/CDK commands can fail. Either drop --ignore-scripts, or follow up with an explicit npm rebuild esbuild (or other allow-listed packages) so required postinstall steps still run while keeping scripts disabled by default.

Suggested change
npm ci --ignore-scripts
npm ci --ignore-scripts
npm rebuild esbuild

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link
Copy Markdown

@anthony-nhs anthony-nhs merged commit 38f40ab into main Apr 15, 2026
19 checks passed
@anthony-nhs anthony-nhs deleted the add_ignore_script branch April 15, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants