build: enable -Werror on rip-and-test and rip-and-test-clang CI builds.#3913
Open
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Open
build: enable -Werror on rip-and-test and rip-and-test-clang CI builds.#3913BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes CI fail if there are any warnings in the standard gcc/g++ or clang/clang++ CI builds (
rip-and-testandrip-and-test-clang). The reason for this move should be clear after the recent mishaps leaving warnings behind in code updates. The current state of the code should be good enough to make -Werror the new standard.It is not (yet) enabled for the package builds because there is some caution required to iron out any potential version problems. Bookworm and Trixie should work, but Sid is a wildcard at this moment. Future evaluation (and possibly fixes) should enable us to add -Werror on all package CI builds too.