GitDownloadStrategy: fix slow repo_valid? by using -C flag#21969
Open
ismail wants to merge 1 commit intoHomebrew:mainfrom
Open
GitDownloadStrategy: fix slow repo_valid? by using -C flag#21969ismail wants to merge 1 commit intoHomebrew:mainfrom
ismail wants to merge 1 commit intoHomebrew:mainfrom
Conversation
Member
|
@ismail Can you fill out the pull request template please? Can you provide before and after benchmark examples? |
MikeMcQuaid
reviewed
Apr 9, 2026
Without -C, git falls back to CWD as the work tree. If CWD is a large directory (e.g. the user's home directory), git status scans the entire tree, making repo_valid? unexpectedly slow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
beb833d to
ec19ead
Compare
Author
Thanks, updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo_valid?runsgit status -swithout specifying-C, so git falls back to the current working directory. If CWD happens to be a large directory (e.g. the user's home directory), this causes git to scan the entire tree, making the call unexpectedly slow.Fix by using
git -C cached_location status -sso git always operates in the correct directory regardless of CWD.Test plan
brew style --fix Library/Homebrew/download_strategy.rbpassesbrew typecheckpassesBefore
Takes more than 10 minutes.
After
brew lgtm(style, typechecking and tests) with your changes locally?