fix: use hardcoded test credentials for custom OkHttpClient test#55
Open
fix: use hardcoded test credentials for custom OkHttpClient test#55
Conversation
The test was using System.getenv() to read API credentials directly, but the Gradle test JVM receives credentials as system properties (from local.properties), not environment variables. Reuse the already- initialized client's credentials, consistent with other tests. Made-with: Cursor
itsmeadi
force-pushed
the
expose-http-client
branch
from
adf24f2 to
a58f5dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testCustomOkHttpClientPreservesConfigtest was usingSystem.getenv()to read API credentials, but in the Gradle test JVM credentials are injected as system properties (fromlocal.properties), not environment variables. This caused aNullPointerExceptioninbuildJWT()whenapiSecretwas null.System.getenv("STREAM_API_KEY")/System.getenv("STREAM_API_SECRET")with hardcoded test credentials so the test works reliably regardless of how credentials are provided.Test plan
./gradlew test --tests "io.getstream.StreamHTTPClientTest"passes (all 8 tests)./gradlew spotlessCheckpassesMade with Cursor