[FEEDS-1373] allow users to provide a custom OkHttpClient#53
Merged
Conversation
Accept a user-supplied OkHttpClient via new constructors on StreamHTTPClient and StreamSDKClient. The SDK derives a new builder from the provided client (preserving its connection pool, timeouts, proxy, SSL config, etc.) and adds the required auth/logging/header interceptors on top. Made-with: Cursor
Verify that a user-provided OkHttpClient's configuration (connection pool, connect timeout, read timeout) is preserved, and that SDK interceptors are still applied on top. Made-with: Cursor
6c4ca2e to
5a65825
Compare
vagruchi
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamHTTPClientandStreamSDKClientthat accept a user-providedOkHttpClient, giving full control over connection pool, timeouts, proxy, SSL, and any other OkHttp setting.client.newBuilder()on the provided client, so the user's configuration is inherited while the SDK's required interceptors (auth, logging, headers) are still applied.Usage:
Test plan
OkHttpClientwith a custom connection pool and pass it tonew StreamSDKClient(key, secret, client)— confirm the pool config is inheritedMade with Cursor