Skip to content

feat: make OkHttp connection pool settings configurable #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsmeadi wants to merge 1 commit into from
Closed

feat: make OkHttp connection pool settings configurable #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/main/java/io/getstream/services/framework/StreamHTTPClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ public class StreamHTTPClient {
public static final String API_TIMEOUT_PROP_NAME = "io.getstream.timeout";
public static final String API_URL_PROP_NAME = "io.getstream.url";
public static final String API_LOG_LEVEL_PROP_NAME = "io.getstream.debug.logLevel";
public static final String CONNECTION_POOL_MAX_IDLE_PROP_NAME =
"io.getstream.connectionPool.maxIdleConnections";
public static final String CONNECTION_POOL_KEEP_ALIVE_PROP_NAME =
"io.getstream.connectionPool.keepAliveDuration";
private static final String API_DEFAULT_URL = "https://chat.stream-io-api.com";

@NotNull private final String sdkVersion = readSdkVersion();
Expand All @@ -48,6 +52,8 @@ public class StreamHTTPClient {
@NotNull private String apiSecret;
@NotNull private String apiKey;
private long timeout = 10000;
private int connectionPoolMaxIdle = 5;
private long connectionPoolKeepAliveDuration = 59;
@NotNull private String logLevel = "NONE";
@NotNull private String baseUrl = API_DEFAULT_URL;
@NotNull private OkHttpClient client;
Expand Down Expand Up @@ -153,6 +159,22 @@ private void readPropertiesAndEnv(Properties properties) {
if (envApiUrl != null) {
this.baseUrl = envApiUrl;
}

var envMaxIdle =
env.getOrDefault(
"STREAM_CONNECTION_POOL_MAX_IDLE",
System.getProperty(CONNECTION_POOL_MAX_IDLE_PROP_NAME));
if (envMaxIdle != null) {
this.connectionPoolMaxIdle = Integer.parseInt(envMaxIdle);
}

var envKeepAlive =
env.getOrDefault(
"STREAM_CONNECTION_POOL_KEEP_ALIVE_SECONDS",
System.getProperty(CONNECTION_POOL_KEEP_ALIVE_PROP_NAME));
if (envKeepAlive != null) {
this.connectionPoolKeepAliveDuration = Long.parseLong(envKeepAlive);
}
}

private @NotNull HttpLoggingInterceptor.Level getLogLevel() {
Expand All @@ -162,7 +184,9 @@ private void readPropertiesAndEnv(Properties properties) {
private OkHttpClient buildHTTPClient(String jwtToken) {
OkHttpClient.Builder httpClient =
new OkHttpClient.Builder()
.connectionPool(new ConnectionPool(5, 59, TimeUnit.SECONDS))
.connectionPool(
new ConnectionPool(
connectionPoolMaxIdle, connectionPoolKeepAliveDuration, TimeUnit.SECONDS))
.callTimeout(timeout, TimeUnit.MILLISECONDS);
httpClient.interceptors().clear();

Expand Down
Loading