Merged
Conversation
tbarbugli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
setConnectionPool(int, Duration)Why
The SDK hardcoded the OkHttp connection pool to 5 idle connections with a 59 second keep-alive. That made it impossible for library users to tune pool capacity through supported SDK options.
Impact
Users can now increase or otherwise tune the SDK client pool size without patching SDK internals.
Supported configuration:
io.getstream.chat.connectionPool.maxIdleConnectionsio.getstream.chat.connectionPool.keepAliveDurationMsSTREAM_CHAT_CONNECTION_POOL_MAX_IDLE_CONNECTIONSSTREAM_CHAT_CONNECTION_POOL_KEEP_ALIVE_DURATION_MSValidation
./gradlew test --tests io.getstream.chat.java.DefaultClientConfigurationTest