Retry pip user installs before breaking system packages#4569
Draft
Nacai (B67687) wants to merge 1 commit intoDevolutions:mainfrom
Draft
Retry pip user installs before breaking system packages#4569Nacai (B67687) wants to merge 1 commit intoDevolutions:mainfrom
Nacai (B67687) wants to merge 1 commit intoDevolutions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
This adjusts the pip retry flow for externally managed environments.
When pip reports
externally-managed-environment, UniGetUI currently retries immediately with--break-system-packages. This change makes the first retry use--userinstead, and only falls back to--break-system-packagesif the user-scoped retry still cannot proceed.That keeps the existing fallback in place, but prefers the less invasive pip path first.
Validation:
mainbranch.dotnet buildlocally because the repository pins .NET SDK10.0.103inglobal.json, while this environment only has6.0.428installed.Follow-up to #4542