Fix OpenGL ES type issues in ACES2 FixedFunction Ops#2281
Open
remia wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Open
Fix OpenGL ES type issues in ACES2 FixedFunction Ops#2281remia wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
remia wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Rémi Achard <remiachard@gmail.com>
doug-walker
approved these changes
Apr 7, 2026
Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Rémi Achard <remiachard@gmail.com>
0f4dc80 to
19892f9
Compare
Signed-off-by: Rémi Achard <remiachard@gmail.com>
19892f9 to
ba9c10a
Compare
Contributor
|
Have not looked at the exact code this now emits, but when I looked at the original issue, I did wonder about the code in the cusp table ... The original blink/c++/etc assumed integer division properties when doing the binary search so used integer types. I guess we'll need to check carefully about all these type conversions and the available function support under the various shader languages. |
Collaborator
Author
|
Just double checked with the OpenGL ES tests I'm running, all tests pass successfully provided I'm using the following defaults precision qualifier (without this almost everything fails). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2269