WAN 2.2 5B it2v Support: Add support for WAN 2.2 VAE and WAN 2.2 it2v 5B model, Fix hacky code in WAN 2.1 VAE#381
Conversation
|
🤖 Hi @entrpn, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pull request introduces support for WAN 2.2 VAE and WAN 2.2 it2v 5B models, while also addressing previously "hacky" frame-reordering logic in the WAN 2.1 VAE. The changes demonstrate a good understanding of the model architecture and JAX/Flax conventions, but some issues were identified in the new autoencoder_kl_wan_2p2.py file, including a critical type-hint/default-value error and leftover debug code.
🔍 General Feedback
- Code Cleanliness: The new
autoencoder_kl_wan_2p2.pyfile contains an excessive amount of commented-out code. Removing these will significantly improve maintainability and readability. - Simplification: Updates to
embeddings_flax.pycorrectly enable multi-dimensional timestep support, which can be further leveraged to simplify the transformer logic. - Robustness: Fixed a frame-reordering issue in WAN 2.1 VAE which improves the overall correctness of the video generation pipeline.
jzr99
force-pushed
the
wan2p2vae
branch
2 times, most recently
from
6efb123 to
ab10595
Compare
entrpn
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.