msvs.py _EscapeCommandLineArgumentForMSBuild() TypeError: can't multiply sequence by non-int of type 'float'

[kuenzign]

In msvs.py, _EscapeCommandLineArgumentForMSBuild() is dividing by 2: return (len(match.group(1)) / 2 * 4) * "\\" + '\\"', however this division results in a float, which causes the multiplication by the string "\\" to throw this error. To fix this, I believe that the division should be changed to use floor division (//), which should correctly return an integer: return (len(match.group(1)) // 2 * 4) * "\\" + '\\"'

This issue causes problems when a define in GYP has backslashes that need to be escaped. For example:

"defines": [
  "TEST_STRING=\\\"TEST\\\"",
]

[cclauss]

node-gyp/gyp/pylib/gyp/generator/msvs.py

Lines 856 to 860 in 19da158

	def _EscapeCommandLineArgumentForMSBuild(s):
	"""Escapes a Windows command-line argument for use by MSBuild."""
	def _Replace(match):
	return (len(match.group(1)) / 2 * 4) * "\\" + '\\"'

"defines": [
-  "TEST_STRING=\\\"TEST\\\"",
+  'TEST_STRING="TEST"',
]