Some gtk windows are still rounded

[the-saddest-clown]

Describe the bug
Some gtk windows don't follow theme to shape the windows.

This bug comes from my Mint-Yz or their Mint-Y ?
The bug is related to a Mint-Yz theme. Tested with all the themes.

To Reproduce

1. Install a Mint-Yz theme from the latest release in /usr/share/themes/
2. Change the theme to use the Mint-Yz theme
3. Open Gnome Disk Utility
4. The window is still rounded

Expected behavior
The gtk window should be squared as the other ones according to the theme.

Screenshots

Desktop (please complete the following information):

• OS: Linux Mint
• OS Version: 21.1
• Desktop Environment: Xfce4.16

[the-saddest-clown]

Happen to the Gnome Calulator to.

[SebastJava]

I know. Thanks for taking some time to open this issue. I agree it doesn't fit very well with the rest of the Mint-Yz-theme. The story is that JosephMcc started making some individual enhancements to a few specific applications, such as the ones displayed here. Those are exceptions. They have 4 rounded corners, not just a rounded top with a square bottom. Those exceptions are coming from https://github.com/linuxmint/mint-themes/blob/master/src/Mint-Y/gtk-3.0/sass/_applications.scss

The thing is:

• While i still prefer my squared windows, i must admit this calculator looks pretty good, with 4 round corners.
• Those exceptions started appearing at a time when i was getting close to publishing another release, and huh, i was just getting tired and/or lazy...

But i will leave this issue opened. I guess i should revert those exceptions, some time later.

P.S.: I am currently very busy. I hope i will be back working on the GTK themes sometime before April...

[the-saddest-clown]

For the moment I just switched to another calculator program, but it's really disgraceful having one app (and an essential one I can't replace) still having those round borders.
I'm trying to tweak the gtk theme to add squared borders to it, any clue where I should look at would be welcome.

[SebastJava]

I am on a new Mint 21.1 fresh install and i did not even find the time to install this Mint-Yz... So i just did a quick test using Mint-Y, but it should be approx. the same story for Mint-Yz.

There is a quick cheating method to find those rounded corners and change them. They are defined by the border-radius CSS property. And they all get a 8px value, for roundness. Lucky you, even if you randomly searched for all the 8px in the gtk.css, there are just a few dozen values like this, so you could quickly sort this out. But lets try to be smarter and faster:

First things first, duplicate your entire Mint-Yz-Dark-Orange70s directory into /home/saddest-clown/.themes Press Ctrl-H to see this hidden directory. Play in this "sandbox" as long as you want, you just can't destroy your system this way...

In your Xed text editor, do:

• Ctrl+F, and click the button for "Regular expression", there in the search bar.
• Search for border-radius:.*8. (that ".*" is a wild-card...)
• Look a few lines up to check what this applies to. Obviously, you don't want to change anything on the scrollbar slider, for example.
• When you find some border-radius with a 8px value somewhere in his attributes, replace those 8px with 0px. Save.
• Change your themes back-and-forth in the themes chooser to force refresh.

result:

[SebastJava]

You want to change those 8px values where it applies to "decoration"...

[SebastJava]

The file you need to tweak is: /usr/share/themes/Mint-Yz-Dark-Orange70s/gtk-3.0/gtk.css

[the-saddest-clown]

@SebastJava Thanks very much for taking the time to give this tutorial, highly appreciated. Will try it soon and gives update here.

[the-saddest-clown]

Nice it work 👍

[SebastJava]

I will re-open this issue, if you don't mind. To remember this later here, or for a future, new Mint-Z.

[SebastJava]

@the-saddest-clown Sorry for not doing any work on this. Here is why: #57

(In there, you will also find some hints about what is possibly coming up next...)